r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@GuillaumeGomez I'm really not sure how changing the size of these elements could cause these test failures, got a clue?

Please add a screenshot. Also, what's the reasoning behind this change? What would it improve?

Motivation is how much stuff gets needlessly truncated:

will add screenshot for what this looks like after the change once I have my new laptop set up more.

here's what it looks like after the change:

This also increases consistency with mdBook, which has a much wider sidebar by default

The difference is (was?) that mdBook and even the rustdoc file panel are trees whereas the rustdoc sidebar is (was?) a list.

Anyway, I don't mind the change, we'll just do an FCP first to ensure that everyone else agrees with it. Once done, I can check what's wrong with the gui test failure.

@rfcbot fcp merge

Team member @GuillaumeGomez has proposed to merge this. The next step is review by the rest of the tagged team members:

• @GuillaumeGomez
• @camelid
• @jsha
• @notriddle

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

☔ The latest upstream changes (presumably #140895) made this pull request unmergeable. Please resolve the merge conflicts.

🔔 This is now entering its final comment period, as per the review above. 🔔

Is there a reason this is still marked as draft?

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

.......... (130/138)
.....FFF   (138/138)


/checkout/tests/rustdoc-gui/notable-trait.goml notable-trait... FAILED
[ERROR] `tests/rustdoc-gui/notable-trait.goml` line 249: expected 1 elements, found 0: for command `assert-count: ("//*[@class='tooltip popover']", 1)`

/checkout/tests/rustdoc-gui/pocket-menu.goml pocket-menu... FAILED
[ERROR] `tests/rustdoc-gui/pocket-menu.goml` line 73: `#settings-menu .popover` not found: for command `assert-css: ("#settings-menu .popover", {"display": "block"})`
[ERROR] `tests/rustdoc-gui/pocket-menu.goml` line 81: `#settings-menu a` not found: for command `click: "#settings-menu a"`

/checkout/tests/rustdoc-gui/sidebar-mobile.goml sidebar-mobile... FAILED
[ERROR] `tests/rustdoc-gui/sidebar-mobile.goml` line 37: The following errors happened (for selector `.sidebar`): [expected `-1000px` for key `left`, found `0px`]: for command `assert-css: (".sidebar", {"display": "block", "left": "-1000px"})`
[ERROR] `tests/rustdoc-gui/sidebar-mobile.goml` line 41: The following errors happened (for selector `.sidebar`): [expected `0px` for key `left`, found `-1000px`]: for command `assert-css: (".sidebar", {"left": "0px"})`
[ERROR] `tests/rustdoc-gui/utils.goml` line 10
    from `tests/rustdoc-gui/sidebar-mobile.goml` line 66
    from `tests/rustdoc-gui/sidebar-mobile.goml` line 78: Error: The CSS selector "#settings" was not found: for command `wait-for: "#settings"`

Error: ()
Build completed unsuccessfully in 0:05:03
  local time: Fri May 16 10:48:20 UTC 2025
  network time: Fri, 16 May 2025 10:48:21 GMT